Allow DMs to the MXID of a WhatsApp puppet that doesn't yet exist #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the HS queries the bridge for a WA puppet user that doesn't exist, try to register a Matrix account for it so that later bridge operations may use that puppet.
|
Note that this doesn't check if the puppet's phone number is valid, because it can't: appservice user queries don't include which Matrix user (if any) triggered the query, so the bridge can't immediately know which bridge user's WhatsApp client to use to perform checks. Thus, the phone number check in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
This allows starting a new WhatsApp DM by inviting a Matrix user with an ID of
@whatsapp_<phoneNumber>:domain(or whatever the puppet user template was configured as), as an alternative to using thepmcommand.This feature was already mostly implemented; this PR just fills the holes that were preventing it from working.