Update profile avatar paths & hashes properly #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store updates to profile avatar hashes in signalmeow_contacts - Have puppets use the stored contact avatar hash rather than recomputing it - Have puppets update their avatar path when the profile avatar path changed but the hash did not - Have puppets clear their avatar path when using a contact avatar instead of a profile avatar
tulir
reviewed
Mar 8, 2024
This call was meant to save changes to the Contact's avatar hash, but the hash is no longer stored there, making this call obsolete.
|
As explained here, the problem this PR was thought to fix is no longer present. So that makes this PR just an optional performance change. Other than avoiding an unneeded hash calculation, it also ensures that changes to a puppet's avatar path are saved to the DB when the puppet's profile metadata comes from a Signal profile (not a contact) and the profile avatar path changed but the hash did not. |
AndrewFerr
commented
Mar 12, 2024
| @@ -354,19 +354,19 @@ func (puppet *Puppet) updateAvatar(ctx context.Context, source *User, info *type | |||
| return true | |||
| } | |||
| avatarContentType = http.DetectContentType(avatarData) | |||
| puppet.AvatarPath = info.Profile.AvatarPath | |||
There was a problem hiding this comment.
This was moved to before the return true so that an path change will end up getting saved to the store even when the hash didn't change.
AndrewFerr
force-pushed
the
af/profile-avatar-update-fixes
branch
from
aeb485e
to
f96ad70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover commit from #449 that may still be relevant.
When running the bridge without this change, avatar updates weren't getting saved to the store when I expected them to & new avatars wouldn't appear in Matrix until a bridge restart.