Add config to disallow manual double puppeting #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as some instances may want to discourage users from sharing their Matrix access tokens. Disabling manual double puppeting still allows automatic double puppeting for any server configured with a login shared secret. If both manual and automatic double puppeting are enabled for a user, allow `login-matrix` to replace the server-managed Matrix token with the one given by the command. Also add the `refresh-matrix` command to fix potential issues with automatically-managed double puppet sessions.
tulir
requested changes
Feb 6, 2024
Notably, disallow (but don't hide) manual double puppeting commands for users whose DP tokens are managed automatically. This averts some edge cases that could happen otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as some instances may want to discourage users from sharing their Matrix access tokens.
Disabling manual double puppeting still allows automatic double puppeting for any server configured with a login shared secret.
If both manual and automatic double puppeting are enabled for a user, allow
login-matrixto replace the server-managed Matrix token with the one given by the command.Also add the
refresh-matrixcommand to fix potential issues with automatically-managed double puppet sessions.