Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission level to deny login-matrix #170

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AndrewFerr
Copy link

as some instances may want to discourage users from sharing their Matrix access tokens.

@AndrewFerr
Copy link
Author

Rebased onto the latest release to facilitate clean merging with downstream branches.

@AndrewFerr AndrewFerr marked this pull request as draft February 1, 2024 12:37
@AndrewFerr
Copy link
Author

Putting this in draft while I try writing an alternative approach that should be simpler / less impactful than making a new permission level.

@tulir
Copy link
Member

tulir commented Feb 1, 2024

Having a special value in login_shared_secret_map or double_puppet_server_map to disallow double puppeting per server might work. Technically you could already set a fake address in the url map, which would break double puppeting.

Alternatively, you could just let people enable it if they want 🤔 Adding a check similar to what mautrix-python has to ensure the provided token doesn't have e2ee keys would be a good idea to prevent users from breaking their existing clients, but I don't see any other reason to prohibit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants