goolm: deprecate custom base64 functions for base64.RawStdEncoding #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumner Evans <sumner@beeper.com>
tulir
reviewed
Jan 26, 2024
| @@ -28,14 +29,13 @@ func Pickle(key, input []byte) ([]byte, error) { | |||
| return nil, err | |||
| } | |||
| ciphertext = append(ciphertext, mac[:pickleMACLength]...) | |||
| encoded := goolm.Base64Encode(ciphertext) | |||
| return encoded, nil | |||
| return []byte(base64.RawStdEncoding.EncodeToString(ciphertext)), nil | |||
There was a problem hiding this comment.
The main reason I didn't do this before is that it's effectively doing return []byte(string(base64Bytes)) instead of just return base64Bytes
I'm not sure if the compiler is smart enough to optimize it away, might need to add exbase64 to go-util with some helper methods like func EncodeToBytes(enc *base64.Encoding, data []byte) []byte
There was a problem hiding this comment.
I was more thinking about this as a first step towards wrapping libolm/goolm in a more sane (non-base64-based) API to the Go code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sumner Evans sumner@beeper.com