Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed gitpod installation for Mautic 5.x. #13396

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Fixed gitpod installation for Mautic 5.x. #13396

merged 2 commits into from
Feb 18, 2024

Conversation

ajitdev
Copy link
Contributor

@ajitdev ajitdev commented Feb 18, 2024 •
edited

Q A
Bug fix? (use the a.b branch) [ 5.x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

From - ddev/ddev#5795

TL;DR
As of 16 Feb 2024 the (upstream) old deb.sury.org key is expiring. This key is used for installing PHP packages in the ddev-webserver Docker image. Its expiration may cause failures of apt update or apt install/webimage_extra_packages (with PHP packages).

DDEV v1.22.7 doesn't have this problem, so upgrade to solve any problems you have with PHP packages during ddev start
In DDEV v1.22.6 (if you don't want to upgrade) docker pull ddev/ddev-webserver:v1.22.6 to get an upgraded version with the new package key.

Steps to test this PR:

The gitpod builds for Mautic 5.x versions should build without any errors.

@ajitdev ajitdev marked this pull request as ready for review February 18, 2024 09:16
RCheesley
RCheesley previously approved these changes Feb 18, 2024
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @ajitdev - could you also make a PR on the 5.0 branch as all those PRs will be un-testable without this fix.

@RCheesley RCheesley added T1 Low difficulty to fix (issue) or test (PR) dependencies Pull requests that update a dependency file essential This must be done to close the milestone labels Feb 18, 2024
@RCheesley
Copy link
Sponsor Member

@all-contributors add @ajitdev for code, bugs

@allcontributors allcontributors bot mentioned this pull request Feb 18, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @ajitdev! 🎉

mollux
mollux reviewed Feb 18, 2024
View reviewed changes
Copy link
Contributor

@mollux mollux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajitdev I don't get how this fixes the issue you're referring to.

The issue is solved in DDEV 1.22.7 (see ddev/ddev#5795 (comment)), but you're updating to 1.21.7.

How does that solve the issue?

mollux
mollux requested changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@mollux mollux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Gitpod, and it doesn't work, as 1.21.7 doesn't exist (see https://github.com/ddev/ddev/releases/tag/v1.21.7)

Screenshot 2024-02-18 at 11 46 11

mollux
mollux reviewed Feb 18, 2024
View reviewed changes
.gitpod.Dockerfile Outdated Show resolved Hide resolved
ajitdev and others added 2 commits February 18, 2024 19:28
@ajitdev
Fixed gitpod installation for Mautic 5.x.
000a0bf
@ajitdev @mollux
Update .gitpod.Dockerfile
d576d5c 
Co-authored-by: Mattias Michaux <mattias.michaux@gmail.com>
@ajitdev
Copy link
Contributor Author

ajitdev commented Feb 18, 2024

@mollux - Thank you for the review! It was a typo in the version number. Fixed as suggested.

@ajitdev ajitdev mentioned this pull request Feb 18, 2024
Merged
@ajitdev
Copy link
Contributor Author

ajitdev commented Feb 18, 2024

Thanks for fixing this @ajitdev - could you also make a PR on the 5.0 branch as all those PRs will be un-testable without this fix.

@RCheesley - created #13400

@ajitdev ajitdev requested a review from mollux February 18, 2024 14:28
mollux
mollux approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@mollux mollux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitpod works again with the correct version.

Screenshot 2024-02-18 at 15 34 46

@mollux mollux merged commit db69176 into mautic:5.x Feb 18, 2024
16 checks passed
@mollux
Copy link
Contributor

mollux commented Feb 18, 2024

@ajitdev merged, thanks!

@mollux mollux added the chore Tasks that relate to maintaining this Github repository label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollux mollux mollux approved these changes

@RCheesley RCheesley RCheesley left review comments

Assignees
No one assigned
Labels
chore Tasks that relate to maintaining this Github repository dependencies Pull requests that update a dependency file essential This must be done to close the milestone T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajitdev @RCheesley @mollux