Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lisp introduction for the book, part 1 #195

Merged
merged 12 commits into from
May 15, 2024

Conversation

fominok
Copy link
Contributor

@fominok fominok commented Apr 26, 2024

Hello @mattwparas,

First of all, I'd like to thank you for your efforts in making embedded Lisp for Rust, as well as advocating for it through the actual implementation of a plugin system for Helix.

I've been observing responses from individuals who are resistant to the idea of Lisp as an embedded language for the editor, and in response I've taken it upon myself to write an introductory Lisp chapter for the book. My hope is that this will help broaden the reach of the project and make it more approachable.

While my work is not yet finished, I wanted to share my progress early. If this idea resonates with you, I am eager to continue my efforts.

@mattwparas
Copy link
Owner

Thanks for the PR - I will take a look in the next few days

docs/src/lisp/bindings_scopes.md Outdated Show resolved Hide resolved
docs/src/lisp/overview.md Outdated Show resolved Hide resolved
@fominok fominok requested a review from mattwparas May 7, 2024 09:06
docs/book.toml Outdated Show resolved Hide resolved
Copy link
Owner

@mattwparas mattwparas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make the distinction between Scheme and Lisp? I don't mind referring to steel as a member of the lisp family (since it is) but in general its origin bears much closer resemblance to scheme, and I'd like that to be reflected in the documentation

@fominok
Copy link
Contributor Author

fominok commented May 11, 2024

Would it be possible to make the distinction between Scheme and Lisp? I don't mind referring to steel as a member of the lisp family (since it is) but in general its origin bears much closer resemblance to scheme, and I'd like that to be reflected in the documentation

hey, I tried to frame it more as a descendant of Scheme now

@fominok fominok requested a review from mattwparas May 11, 2024 07:47
@fominok fominok requested a review from mattwparas May 13, 2024 07:42
@mattwparas
Copy link
Owner

Just the one nit, otherwise I think this looks okay - did you want to get this merged as is? Or continue adding things?

@fominok
Copy link
Contributor Author

fominok commented May 15, 2024

Just the one nit, otherwise I think this looks okay - did you want to get this merged as is? Or continue adding things?

Thanks for the review, I planned to do more PRs to make them more manageable as I'm not quite sure where is the point when I find it "done", so this one could be merged

@fominok fominok requested a review from mattwparas May 15, 2024 15:01
@mattwparas mattwparas merged commit 49cd3b9 into mattwparas:master May 15, 2024
3 checks passed
@fominok fominok deleted the v0.5.0-book branch May 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants