Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GDBus instead of deprecated dbus-glib #84

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use GDBus instead of deprecated dbus-glib #84

wants to merge 3 commits into from

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Apr 17, 2020

dbus-glib is deprecated since Debian stretch (Debian 9) and Ubuntu 18.04 (bionic) or later

@kenhys
Drop checking deprecated dbus-glib module
3266bb2 
It is recommended to use GDBus instead.
@kenhys
Use GDBus instead of dbus-glib
f01b230 
dbus-glib is deprecated since Debian stretch (Debian 9) and
Ubuntu 18.04 (bionic)
@kenhys
Change condition to notify when title, artist or album is changed
efdd049 
It is incompatible change

BEFORE:
  Notify if title and artist and album is changed

AFTER:
  Notify if either title or artist or album is changed
@kenhys kenhys changed the title WIP: Use GDBus instead of deprecated dbus-glib Use GDBus instead of deprecated dbus-glib Apr 24, 2020
@kenhys kenhys marked this pull request as ready for review April 24, 2020 01:01
@kenhys
Copy link
Contributor Author

kenhys commented Apr 24, 2020

As I mentioned above, #84 (comment)

https://developer.gnome.org/dbus-glib/unstable/ says:

dbus-glib is a deprecated API for use of D-Bus from GLib applications. Do not use it in new code.
Since version 2.26, GLib's accompanying GIO library provides a high-level API for D-Bus, "GDBus", based on an independent reimplementation of the D-Bus protocol. The maintainers of D-Bus recommend that GLib applications should use GDBus instead of dbus-glib.

So I've fixed to use GDBus instead of dbus-glib in this PR.

Note that there is one incompatible changes about timing of notification.
In the previous versions, when all of title, artist, album is changed, notification is kicked, but in this PR, either title or artist or album is changed, notification is kicked. I think it is better behavior even though it breaks compatibility. any thought about it? @mattn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kenhys