Xcode 9.1 & Swift 4 support #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing was really necessary. Note that I couldn't use the migration wizard. It made Xcode 9.1 crash 4 out of 4 times. What I did was simply bumping the Swift version in the project file, and ensuring it built all right.
|
I am wondering what's the plan for this. Because as far as I know, Swift 4 already have native support for JSON encoding and decoding. |
|
@yzhong52 my 2 cents. I use this library in a side project that is live in the Store. I don't have much time to spend on that project, moving to Swift's native |
|
And looking at your diff, there is no code change at all for Swift 4? |
|
@mokagio also it looks like the build doesn't pass with your changes. https://travis-ci.org/matthewcheok/JSONCodable/builds/300894536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the project to be in line with Xcode 9.1 and Swift 4.