Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57919] Use new host controls ws msgs #735

Merged
merged 3 commits into from May 14, 2024
Merged

[MM-57919] Use new host controls ws msgs #735

merged 3 commits into from May 14, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented May 13, 2024

Summary

  • Update calls-common, refactor to use new host control ws msg definitions

Ticket Link

cpoile
cpoile commented May 13, 2024
View reviewed changes
standalone/src/init.ts Outdated Show resolved Hide resolved
@cpoile cpoile requested a review from streamer45 May 13, 2024 14:12
@cpoile cpoile added 2: Dev Review Requires review by a core committer Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels May 13, 2024
streamer45
streamer45 approved these changes May 13, 2024
View reviewed changes
standalone/src/init.ts Outdated Show resolved Hide resolved
webapp/src/websocket_handlers.ts Outdated Show resolved Hide resolved
standalone/src/init.ts Outdated Show resolved Hide resolved
@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 14, 2024
@streamer45 streamer45 added this to the v0.27.0 / MM 9.9 milestone May 14, 2024
Base automatically changed from MM-57953-host-notices to main May 14, 2024 20:30
@cpoile cpoile removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 14, 2024
@cpoile cpoile merged commit dccb5e3 into main May 14, 2024
19 checks passed
@cpoile cpoile deleted the MM-57919-host-ws-msgs branch May 14, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.27.0 / MM 9.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpoile @streamer45