Fix live captions icon #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
reviewed
May 14, 2024
Comment on lines
+15
to
+17
| width='20' | ||
| height='20' | ||
| viewBox='2 3 20 18' |
There was a problem hiding this comment.
Are you getting this from the svg itself (i.e. did it change)? Because I cut and pasted the svg originally, and afaik you don't need to change this in the svg, you just do what you did in the style above. But if it did change, then great!
There was a problem hiding this comment.
@cpoile I always crop them because it has caused too much pain and inconsistencies to have weird spacing between the actual glyphs.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are keeping #719 out of the upcoming release, we need to update the CC icon which is still using the previous sizing.