[MM-57909] Remove single-handler mode #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
Apr 18, 2024
Comment on lines
-588
to
-610
| state, err := p.getCallState(channelID, false) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This is actually significant from a perf perspective since fetching the state is one of the heaviest operations we make.
streamer45
added
3: Reviews Complete
streamer45
removed
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR fully deprecates the single-handler mode. This was implemented as a workaround to run Calls in Kubernetes (HA) before
rtcdexisted but now it's just adding more complexity to both code and documentation. I say farewell 馃憢Ticket Link
https://mattermost.atlassian.net/browse/MM-57909