[Gekidou] Get all existing server credentials on init #5468
Conversation
| @@ -106,7 +149,7 @@ export const getServerCredentials = async (serverUrl: string): Promise<ServerCre | |||
|
|
|||
| // TODO: Create client and set token / CSRF | |||
There was a problem hiding this comment.
Can do in the PR that brings in the network lib
| - libwebp/mux (= 1.1.0) | ||
| - libwebp/webp (= 1.1.0) | ||
| - libwebp/demux (1.1.0): | ||
| - libwebp (1.2.0): |
| diff --git a/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m b/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m | ||
| index 38ccdf3..2875032 100644 | ||
| --- a/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m | ||
| +++ b/node_modules/react-native-keychain/RNKeychainManager/RNKeychainManager.m |
There was a problem hiding this comment.
do we want to submit this patch upstream?
There was a problem hiding this comment.
Yep, just gotta fix the patch.
There was a problem hiding this comment.
| @@ -4,16 +4,56 @@ | |||
| import {Platform} from 'react-native'; | |||
| import AsyncStorage from '@react-native-community/async-storage'; | |||
There was a problem hiding this comment.
When sorting imports, the @react-native-community/async-storage should be treated as the character a and sorted amongst the first modules.
app/init/credentials.ts
Outdated
|
|
||
| setServerCredentials(serverUrl, credentials!.userId, credentials!.token); | ||
|
|
||
| const normalizedServerUrl = normalizeServerUrl(serverUrl); |
There was a problem hiding this comment.
I'm having my doubts about normalizing.. let's chat about this
There was a problem hiding this comment.
Removed normalization. We're now OK with the the server URL containing the protocol in both the keychain and in the db. If we want to match against a deeplink URL, we can always use a LIKE query or replace the deeplink protocol prior to querying.
migbot
changed the title
enahum
added
4: Reviews Complete
Summary
Gets all existing server credentials on init for use with initializing the DatabaseManager and the NetworkClientManager. The keychain library on the iOS side needed patching to support extracting all server URLs from internet credential entries.
Release Note