Tweak spacing in responsive layout files for mobile #1359
Merged
+13
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also helps developer experience by replacing home-made CSS selectors with Bootstrap 4's utilities. Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
@cwarnermm Thoughts? |
cwarnermm
added
2: Editor Review
|
Newest code from cwarnermm has been published to preview environment for Git SHA b8dcfd6 |
1 similar comment
|
Newest code from cwarnermm has been published to preview environment for Git SHA b8dcfd6 |
|
update-branch |
cwarnermm
added
preview-environment
|
Newest code from cwarnermm has been published to preview environment for Git SHA b8dcfd6 |
|
update-branch @cwarnermm |
|
@emdecr - Are you open to taking a peek at this dev docs PR, please? I'd love to get your input on the proposed changes. |
|
@cwarnermm Sure thing - will circle back within the next day or so. |
emdecr
approved these changes
May 27, 2024
There was a problem hiding this comment.
@cwarnermm These standardizations make sense to me 👍
Looking around they don't seem to break anything.
cwarnermm
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tweaks many spacing in responsive layout files mainly for mobile to reduce unexpected horizontal drifts on mobile screens.
This PR also helps developer experience by replacing home-made CSS selectors with Bootstrap 4's utilities.
Ticket Link
This change is a groundwork for Hugo layouts and not relevant to any specific feature(s).