fix: remove test() functions to display correct coverage #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimazhornyk
requested review from
vladbochok and
StanislavBreadless
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Removed some
test()functions from intermediary contracts to display correct coverage, and added new test.Current coverage stats:
Why ❔
The usage of
test()function indeed removes the unneeded files (like files fromdev-contractsfolder) from the coverage report, but it results in the coverage not being displayed for the libraries. I removed those functions temporarily, so we could see the real libraries coverage(unfortunately, we will see the dev-contracts as well, but I proposed a small change to foundry foundry-rs/foundry#7301, that would allow us to ignore those files in the future).Checklist