update the template to declare the input args as a struct type #54

hcliff · 2018-04-13T18:59:30Z

instead of redefining a struct repeatedly create a type to declare the input args.

My motivation was to allow me to make assertions on this call in my tests (ginkgo/gomega in the example below) without needing to redeclare the struct myself

Eventually(func() []listservicesstub.PersistListsCall {
  return elasticStub.PersistListsCalls()
}).Should(ConsistOf(listservicesstub.PersistListsCall{
  Lists: []models.List{newList},
}))

100% backwards compatible and actually results in less generated code

hcliff · 2018-07-23T18:40:21Z

any thoughts about this? would love to get it merged

matryer · 2018-07-24T12:03:59Z

pkg/moq/template.go

-	calls = mock.calls.{{.Name}}
-	lock{{$obj.InterfaceName}}Mock{{.Name}}.RUnlock()
-	return calls
+	defer lock{{$obj.InterfaceName}}Mock{{.Name}}.RUnlock()


Could we have this on two lines? I'm not a fan of compressing code onto one line at the cost of readability?

matryer · 2018-07-24T12:04:36Z

pkg/moq/template.go

 {{- end }}
 	}
 }
 {{ range .Methods }}
+
+// {{.Name}}Call represents the input arguments to {{.Name}}
+type {{.Name}}Call struct {


How much noise does this add to the API?

matryer · 2021-02-02T06:59:48Z

Hey @hcliff - thank you so much for this. I wonder if the additional types in the package space end up cluttering it too much? What do you think?

update the template to declare the input args as a struct

d3e6ba2

hcliff changed the title ~~update the template to declare the input args as a struct~~ update the template to declare the input args as a struct type Apr 13, 2018

matryer reviewed Jul 24, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update the template to declare the input args as a struct type #54

update the template to declare the input args as a struct type #54

hcliff commented Apr 13, 2018

hcliff commented Jul 23, 2018

matryer Jul 24, 2018

matryer Jul 24, 2018

matryer commented Feb 2, 2021

update the template to declare the input args as a struct type #54

Are you sure you want to change the base?

update the template to declare the input args as a struct type #54

Conversation

hcliff commented Apr 13, 2018

hcliff commented Jul 23, 2018

matryer Jul 24, 2018

Choose a reason for hiding this comment

matryer Jul 24, 2018

Choose a reason for hiding this comment

matryer commented Feb 2, 2021