Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat-issue-68: add copy to clipboard FQDN in mission view #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat-issue-68: add copy to clipboard FQDN in mission view #145

wants to merge 2 commits into from

Conversation

TdeBoynes
Copy link

@TdeBoynes TdeBoynes commented Dec 7, 2021 •
edited

Q A
Branch? feat-issue-68-add-copy-to-clipboard-FQDN-in-mission-view
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...

@TdeBoynes TdeBoynes marked this pull request as draft December 7, 2021 19:32
@TdeBoynes TdeBoynes changed the title add copy to clipboard FQDN in mission view feat-issue-68: add copy to clipboard FQDN in mission view Dec 7, 2021
darkweak
darkweak approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@darkweak darkweak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenaye jenaye marked this pull request as ready for review December 21, 2021 00:19
@jenaye
Copy link
Member

jenaye commented Dec 21, 2021

Hello, @HKtueur1 @JulietteDestang good job, now you have to fix cypress tests

@jenaye jenaye requested a review from darkweak December 21, 2021 00:21
@darkweak darkweak force-pushed the feat-issue-68-add-copy-to-clipboard-FQDN-in-mission-view branch from de594a9 to 53a7bab Compare January 7, 2022 19:16
@darkweak darkweak force-pushed the feat-issue-68-add-copy-to-clipboard-FQDN-in-mission-view branch from 53a7bab to 2be8ebf Compare January 7, 2022 19:18
@darkweak darkweak force-pushed the feat-issue-68-add-copy-to-clipboard-FQDN-in-mission-view branch from f538298 to 1d6ddde Compare January 7, 2022 21:28
@darkweak darkweak force-pushed the feat-issue-68-add-copy-to-clipboard-FQDN-in-mission-view branch from 1d6ddde to 17a265d Compare January 7, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkweak darkweak darkweak approved these changes

Assignees

@JulietteDestang JulietteDestang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TdeBoynes @jenaye @darkweak @JulietteDestang