Improve tests/subtests
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
reviewed
May 28, 2022
ConorMacBride
commented
May 28, 2022
| os.path.realpath(tempfile.gettempdir()), # replace all references to output files | ||
| ] | ||
| REGEX_STRS = [ | ||
| r'RMS Value: ', |
bjlittle
reviewed
May 28, 2022
bjlittle
reviewed
May 28, 2022
bjlittle
approved these changes
May 28, 2022
There was a problem hiding this comment.
@ConorMacBride Lovely. Looking forward to using this straight away for #150 👍
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
tests/subtestscan be updated/regenerated automatically without needing to manually adjust the baseline data.To create the baseline images and hashes run:
Then, to create the baseline summaries run:
Finally check the
git diffand run the standard tests before committing:I will add documentation for this in a README file in
tests/subtests.All changes are isolated to within
tests/subtestsexcept I've addedPillow(imported asPIL) as a dependency. (Matplotlib already requires this package and #150 will need it also.) And I have made some minor changes totox.ini.Interestingly, removing the matplotlib version number from the PNGs means that all the hashes are identical across matplotlib 3.3, 3.4 and 3.5!! (I guess this isn't too surprising since the plots are very basic.)
Closes #159