Revert "Merge pull request #723 from matomo-org/pg-2764-retry-mtm-tracking-improvement"

[snake14]

This reverts commit 1eed6a4, reversing changes made to 5cb1114.

Description:

Reverting the MTM changes to try making it work better with _paq.push. The changes are once again causing unexplained data loss.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[AltamashShaikh]

@snake14 All looks good, the only difference I see is this code moved to top from previous code, should we move to bottom again ? Rest all looks good to be merged

[snake14]

@snake14 All looks good, the only difference I see is this code moved to top from previous code, should we move to bottom again ? Rest all looks good to be merged

Thanks @AltamashShaikh . I intentionally moved those lines because I didn't think that they were in the right place. It probably doesn't really matter, though. What do you think?

[AltamashShaikh]

@snake14 All looks good, the only difference I see is this code moved to top from previous code, should we move to bottom again ? Rest all looks good to be merged

@snake14 It should not matter 👍

[snake14]

@matomo-org/core-team I just merged this PR. Can we please make sure that it gets tagged for the next 5.1.0 beta release?