Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV-17995 design review tweaks #22171

Merged
merged 10 commits into from May 6, 2024
Merged

DEV-17995 design review tweaks #22171

merged 10 commits into from May 6, 2024

Conversation

michalkleiner
Copy link
Contributor

Description:

As per the individual commits, this PR includes changes requested after going through a design review with the design team:

  • screenshot images full width figure background with figcaption alinged to the left
  • remove featured plugin star from the plugin title
  • collapse header when no metadata to show (such as for bundles)
  • full screen takeover on mobile devices under 480px wide
  • full width CTA in the footer with hidden Matomo badge on mobile devices under 480px wide

Review

@michalkleiner michalkleiner added c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Apr 29, 2024
@michalkleiner michalkleiner added this to the 5.1.0 milestone Apr 29, 2024
@michalkleiner michalkleiner requested a review from a team April 29, 2024 15:48
@michalkleiner michalkleiner force-pushed the dev-17995-design-review branch 3 times, most recently from c58502e to 5d2b4bb Compare April 30, 2024 19:53
@michalkleiner michalkleiner added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 2, 2024
@michalkleiner michalkleiner merged commit e99a6b6 into 5.x-dev May 6, 2024
43 of 50 checks passed
@michalkleiner michalkleiner deleted the dev-17995-design-review branch May 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert Awaiting requested review from mneudert

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalkleiner @mneudert