Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Investigate performance improvements from using a segment-action link table #21966

Draft
wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Feb 22, 2024

⚠️ DO NOT MERGE ⚠️

Description:

This is a work-in-progress, proof-of-concept pull request for #19581 to investigate potential archiving performance improvements by using link tables to match segment parts to actions using primary keys instead of string matching the action name each time.

As a first step this includes a console command to generate link tables and back-fill them with data based on the existing segments and actions in the current dataset. This is a quick way to allow performance testing to validate the approach, it is not intended as production code and therefore not all segment actions are supported.

The console command is:
./console development:build-salt
Run without parameters it will generate the tables and using site specific segment parts.
--v for more output
--nosites to generate without site specific parts (all actions can be matched to any site)
--drop remove the new link tables

⚠️ DO NOT MERGE ⚠️

Review

@bx80 bx80 added c: Performance For when we could improve the performance / speed of Matomo. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 22, 2024
@bx80 bx80 self-assigned this Feb 22, 2024
@michalkleiner michalkleiner changed the title Investigate performance improvements from using a segment-action link table [PoC] [PoC] Investigate performance improvements from using a segment-action link table Feb 25, 2024
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Mar 11, 2024
@michalkleiner michalkleiner added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Mar 11, 2024
@michalkleiner michalkleiner marked this pull request as draft March 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants