Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes SEO plugin (widget) #21780

Open
wants to merge 5 commits into
base: 5.x-dev
Choose a base branch
from
Open

Removes SEO plugin (widget) #21780

wants to merge 5 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 8, 2024

Description:

Matomo was providing a SEO widget, which allowed to fetch some stats around indexed pages on e.g. Google, Bing or Alexa. This widget failed to fetch its stats (on cloud) more and more, making the widget mostly useless.

Also when it comes to “SEO” in a dashboard, this widget under-delivers on what people would hope to see. We therefore decided to remove the widget.

If anyone would like to keep the widget please create an issue for that, and we might consider releasing it as a separate plugin instead.

refs #21712

Review

@sgiehl sgiehl modified the milestones: 5.0.2, 5.1.0 Jan 8, 2024
@sgiehl sgiehl requested a review from a team January 8, 2024 15:26
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 8, 2024
@tsteur
Copy link
Member

tsteur commented Jan 8, 2024

As this is a breaking change, can we add the changelog entry? Wondering actually if we should keep the plugin itself and keep the API returning an empty datatable and only remove the widget so we're not breaking the HTTP API? In Matomo 6 we could then break the API and remove the entire plugin.

@sgiehl
Copy link
Member Author

sgiehl commented Jan 9, 2024

@tsteur please discuss this with @mattab. The target was to remove this feature with lowest effort.
Personally I would have kept the feature and only disabled it on cloud (as it seems too much effort to test a possible fix there). Or alternatively move it to a plugin on marketplace, so at least on prem users still finding it valuable could still use it.

@sgiehl sgiehl removed the request for review from a team January 9, 2024 08:40
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jan 9, 2024
@tsteur
Copy link
Member

tsteur commented Jan 11, 2024

@sgiehl I think the issue was maybe to remove the widget, not the plugin?

The target was to remove this feature with lowest effort.

I'd say it was about the lowest effort while still keeping our promises such as that we won't break our APIs. It could be even fine to only remove the Widget file itself and the rest in Matomo 6. This way it would have been very little effort to just remove the widget file without breaking the HTTP API etc.

Personally I would have kept the feature and only disabled it on cloud

It's overall fine to remove it as it provides very little value nowadays.

Breaking the API can be an issue. For example the Matomo Connect WordPress plugin uses the API in https://github.com/braekling/WP-Matomo/blob/master/classes/WP_Piwik/Widget/Seo.php#L14 etc.

@sgiehl
Copy link
Member Author

sgiehl commented Jan 11, 2024

In that case, we will move removing that plugin to Matomo 6. If it is causing problems on Cloud we can simply disable the plugin there. On premise it was working as expected anyway.

@sgiehl sgiehl modified the milestones: 5.1.0, 6.0.0 Jan 11, 2024
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 26, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants