New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache and restore system LC_CTYPE option after all other locales are set #21127
base: 5.x-dev
Are you sure you want to change the base?
Conversation
According to the PHP docs, https://www.php.net/manual/en/function.setlocale.php When the argument
Are these both blank/empty string for your local environment. The reason for asking the question is to really nail down exactly why it was breaking in the first place.
|
I think it's not just what I can access as a user in my shell, it's about what nginx or php-fpm is running with, and when testing from plain php script with
it immediately failed the same way. |
I also tried setting |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
@shafeek-innocraft Had this problem setting up a new matomo install too. |
I did as well switching from using the built in PHP server to using Nginx + PHP-FPM ➕ |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
I can confirm this PR resolves the issue for me. |
Hi @rikwillems, could you please let us know a bit about your current dev environment setup? |
Hi @michalkleiner I just started experimenting with Matomo a little bit. Last week I was able to install without any issue. Today I tried again and ran into this issue. I'm using Valet on php 8.1. Also tried php 8.0, same issue. For debug I tried a try/catch but that didn't do anything, same 502 error. |
@michalkleiner I forgot to mention at the time that when we encountered this the PR did actually solve the issue. |
Description:
Tweak for #21126 that should be functionally equivalent.
Even repeated calls to changing the locale should persist the value for LC_CTYPE from the very first call.
Review