New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for goal attribution #20442
base: 4.x-dev
Are you sure you want to change the base?
Conversation
plugins/Goals/lang/en.json
Outdated
@@ -6,6 +6,8 @@ | |||
"AddNewGoalOrEditExistingGoal": "%1$sAdd a new Goal%2$s or %3$sEdit%4$s existing Goals", | |||
"AllowGoalConvertedMoreThanOncePerVisit": "Allow Goal to be converted more than once per visit", | |||
"AllowMultipleConversionsPerVisit": "Allow multiple conversions per visit", | |||
"AttributionTitle": "Attribution", | |||
"AttributionDocumentation": "Conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might actually not always be true. This only works when using javascript tracking and only if the javascript tracker method setConversionAttributionFirstReferrer
wasn't called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we say by default for javascript tracker if that's the case? or it will attribute to first if setConversionAttributionFirstReferrer
was called?
"AttributionDocumentation": "Conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted.", | |
"AttributionDocumentation": "Conversion metrics in tables with Goal metrics are attributed to the last non-direct channel, if `setConversionAttributionFirstReferrer` was called it will attribute to first non-direct channel that brought visitors who converted.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @Stan-vw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As conversion attribution is a bit more complexe and might be subject to change I think we should maybe only mention the default case and create and link to a FAQ that documents the behavior and possibilities a bit more detailed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a FAQ that documents this behaviour?
- if so, I suggest we change the line to "By default, conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted. Learn more about conversion attribution." where the hyperlink goes to the complementary FAQ
- if not, I suggest we change the line to "By default, conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there is an FAQ.
But keep in mind, that last non-direct might not be correct in all cases.
When the visitor was visiting the page with campaign parameters in a previous visit, a conversation would be attributed to this campaign even if the conversions visit was coming from another non-direct referer like a search engine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the FAQ we have
@sgiehl will this be fine ?
"AttributionDocumentation": "Conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted.", | |
"AttributionDocumentation": "By default, conversion metrics in tables with Goal metrics are attributed to the last non-direct channel that brought visitors who converted. %1$sLearn more%2$s about conversion attribution." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds right to me @AltamashShaikh , thanks for progressing this so rapidly 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw The FAQ would probably be more this one: https://matomo.org/faq/general/what-is-the-default-attribution-model-used-in-matomo/
For now I'll move this to a future milestone along with the other relevant: #20516 #20515
@sgiehl Can we merge this ? |
I'm still not sure if we should add that, as it's not correct in various cases (not even the default one):
I really think it's good to document that in the software and in FAQs, but adding documentation that isn't correct is ihmo worthless. But if @Stan-vw and @mattab have another opinion on that, I'm happy to discuss and merge it if needed. |
Thanks for your feedback
This is actually a bug, I'll create an issue for it
I thought attribution would also work without cookies, because the log_visit row has the channel/referrer information, and this is copied in the log_conversion row during the conversion, right? Or is this not how it works? |
No it doesn't. If no value is passed by javascript, it will use the currents visits referrer. There are no look ups for previous referrers of the same visitor or similar, which would be needed to attribute it to e.g. last/first non-direct referrer or similar. matomo/plugins/Referrers/Columns/Base.php Lines 612 to 680 in df8fe4f
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
@sgiehl Q: Could we maybe merge this PR or is logically incorrect to a point we can't merge it? |
The added details are not fully correct. So I don't see any benefit in merging it. |
I wonder what the text would read, if it was to be 100% correct? Would that somehow be possible maybe, with the current way attribution works? |
The attribution currently depends on various things. There are various configurations that affect the attribution, and it depends on the javascript tracker, e.g. if cookies can be used or not and if the tracker method to change the attribution has been used or not. To me the implementation of the attribution is currently very fragile and I'm not sure if it works correctly in all cases. But I really don't want to spent more time onto investigating how it currently works without knowing how it actually should work. |
Description:
Added documentation for goal attribution.
Fixes: #PG-2659
Review