129 - Creation of dynamic property MatomoTracker::$currentTs is deprecated #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for starting the PR @lutdev. Is there a reason to have the properties public? Are they used outside of the class? I'd imagine they can be private, protected at most. What do you think? |
|
@michalkleiner you are welcome :) The main reason to make not breaking changes. If the properties will be public, developers still can use them as they use them now. Later we can try to make them private/protected step by step. |
|
@michalkleiner just a friendly reminder about PR :) |
sgiehl
reviewed
May 2, 2024
sgiehl
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I created properties to fix the problem with the dynamic properties. All default values I took from the
__construct()Issue: #129
I would be happy to update CHANGELOG but have no idea how my updates should look like.