Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make express and cookie types dependencies #555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

boredland
Copy link

@boredland boredland commented Jun 20, 2022

closes #492

I have no yarn2 experience at all. I did run yarn set version berry before running yarn install, I thought that was the right thing to do.

@boredland
Copy link
Author

hey @maticzav, are you interested in this? I could rebase this PR, if you want.

@Canoir
Copy link

Canoir commented Sep 13, 2023

i had the samething for running project and i change yarn-berry to yarn-3.. and everything was ok (with yarn set version berry).

but why we should change types to deps? these are only Types for typescript and at the end we need them only before building the project, so i think this could harm the package size and we should seek a better solution for that.

@boredland
Copy link
Author

Did you read the issue this relates to? Iirc, some types exposed by this library rely on these, not installing them makes them any. That being said: this PR is ages old and probably this could be solved with a different approach to packaging/bundling.

@boredland
Copy link
Author

GPAVx3qXQAAvF3v.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

express and cookie typings are not available automatically
2 participants