ChargemolAnalysis auto-download atomic densities if not found
#3465
+117
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
enhancement
janosh
force-pushed
the
chargemol-auto-download
branch
from
0cfcc16
to
c3583fe
Compare
janosh
force-pushed
the
chargemol-auto-download
branch
from
96143ba
to
26acf13
Compare
janosh
force-pushed
the
master
branch
2 times, most recently
from
3c23114
to
36e289c
Compare
janosh
force-pushed
the
master
branch
4 times, most recently
from
d725325
to
dca98be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to materialsproject/atomate2#587 and materialsproject/emmet#869.
Pinging @chiang-yuan in case you want to take this over. The tests are still WIP and I didn't do any real-life robustness testing yet. E.g. do we gracefully bail if running on HPC with no network connection?