BUG FIX: BSDOSPlotter.get_plot #2913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 2288 change to ```py if isinstance(dos, CompleteDos): # Dos obj has no structure ```
janosh
reviewed
Mar 27, 2023
| bandstr = BandStructureSymmLine.from_dict(bandstr_dict) | ||
| plt = p.get_plot(bandstr) | ||
| band_struct = BandStructureSymmLine.from_dict(band_struct_dict) | ||
| plt = plotter.get_plot(band_struct) |
There was a problem hiding this comment.
Could you add a line here that calls plotter.get_plot() with a Dos object? Just to cover this execution branch?
janosh
added
the
needs testing
janosh
force-pushed
the
master
branch
2 times, most recently
from
3c23114
to
36e289c
Compare
janosh
force-pushed
the
master
branch
4 times, most recently
from
d725325
to
dca98be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 2288
change to
The DOS object has no structure property, which causes error if parsing DOS data without projection.
This modification allows user to plot BS and TDOS at the same time, while keeping the BS+PDOS plotting not affected.
Cheers.