Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Kotlin Multiplatform Support #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DatL4g
Copy link

@DatL4g DatL4g commented Feb 13, 2023

This adds a Kotlin Multiplatform library people asked for months.

Closes #49 and closes #54

May require more improvements, however it's current state is at least the same state as the java (+ further methods e.g. create Theme from Image on Android and JVM).

I know this repo normally doesn't accept PRs currently, however I think it's better to merge and add this now, as it's more useful to maintain this than improving the java library

@google-cla
Copy link

google-cla bot commented Feb 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

* <p>Analogous colors, complementary color, and cache to efficiently, lazily, generate data for
* calculations when needed.
*/
class TemperatureCache(private val input: Hct) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the file name, there is a missing e 🙂

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gets considered to merge, I can fix it.
However the filename doesn't really matter in Kotlin, so it's not urgent

@mon-jai
Copy link

mon-jai commented Feb 28, 2023

IIRC Google doesn't accept pull requests to this repo.

@DatL4g
Copy link
Author

DatL4g commented Feb 28, 2023

IIRC Google doesn't accept pull requests to this repo.

@mon-jai read description

@danielesegato
Copy link

danielesegato commented May 8, 2023

@DatL4g if you want them to consider your pull request you need to sign the CLA as per #76 (comment) otherwise I doubt they'll even check the submission

@DatL4g
Copy link
Author

DatL4g commented May 8, 2023

@danielesegato I did when I opened the PR it just doesn't update the status here, but they know it's signed
The PR needs a rebase anyway, if they consider a merge I'm going to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Kotlin Multiplatform support Kotlin Library
4 participants