Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sourceColorFromImage bug if image load complete and partly image #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mindon
Copy link

@mindon mindon commented Aug 10, 2022

  1. fix load complete image bug
  2. support using part of image with data-area

This repo is not currently accepting external contributions, but feature
requests and bug reports are very welcome!

…g data-area="sx,sy,sw,sh" /> with part of image
@guidezpl
Copy link
Collaborator

guidezpl commented Feb 9, 2023

@rodydavis could you please take a look at integrating this change?

@rodydavis
Copy link
Member

Integrated on internal change that we will push out

@guidezpl
Copy link
Collaborator

guidezpl commented Mar 6, 2023

thanks!

@rodydavis
Copy link
Member

landed on the latest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants