Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python material-color-utilities library #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avanisubbiah
Copy link

This repo is not currently accepting external contributions, but feature
requests and bug reports are very welcome!

Pull request to add python material-color-utilities library requested in issue #26

@google-cla
Copy link

google-cla bot commented Jul 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pennzht
Copy link
Collaborator

pennzht commented Aug 9, 2022

Hello @avanishsubbiah,

Thank you for creating this PR!

Please note that we require Python PRs to follow the Google Python Style Guide. We would really appreciate it if you could update your PR, making it conform to these standards.

For example, the following changes should be made:

  • Documenting code with docstrings instead of comments.
  • Removing extraneous parentheses, such as in if (clippedLstar < tone):
  • Using idiomatic Python, such as for pixel in pixels: instead of for i in range(len(pixels)):
  • Using snake_case for method names, such as construct_histogram instead of constructHistogram
  • Limiting all lines to 80 characters.

Also, please sign the CLA (see above comment for details).

Again, we really appreciate your effort in contributing to the library! Please let us know if you need any help or guidance on this PR.

@pennzht
Copy link
Collaborator

pennzht commented Oct 5, 2022

Hello @avanishsubbiah,

How is everything going?

We would like to know whether you are still working on completing this PR.

Looking forward to hearing from you!

@avanisubbiah
Copy link
Author

Hello,

I've been busy with a university design project, but I should be able to make the changes listed above soon. I have signed the CLA but it doesn't show up in the PR.

Thanks!

@guidezpl guidezpl added the library: new Adding a new language/library label Feb 9, 2023
@T-Dynamos
Copy link

I would like to inform that this implementation is very slow, it takes 3min and 49secs to get dominant color. But if we use this implementation for getting dominate color, then this could be better, it just takes 0.23 secs to get dominant color. I was able to make minimal example in python gui framework Kivy
image
(Here image is 5.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library: new Adding a new language/library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants