Use StackedSparseArray for MetadataMatch sparse equal_match
#642
Conversation
zargham-ahmad
changed the title
equal_matchequal_match sparse array_type
zargham-ahmad
changed the title
equal_match sparse array_type
zargham-ahmad
changed the title
equal_match sparse array_type
zargham-ahmad
changed the title
equal_match sparse array_typesparse equal_match
|
Not completely related to this PR, but I did not look at the MetadataMatch class before, the difference between "equal_match" and "difference" was not fully clear to me at first glance. Can you maybe add a bit of extra docstring here @zargham-ahmad? And maybe we should also give a warning if a tolerance is given, but matching_type is set to "equal_match". |
| if array_type not in ["numpy", "sparse"]: | ||
| raise ValueError("array_type must be 'numpy' or 'sparse'.") | ||
|
|
There was a problem hiding this comment.
Good addition - this should be covered by a unit test though to make sure this specification is tracked.
There was a problem hiding this comment.
test added in 24a8ecb
done in 24a8ecb |
|
@zargham-ahmad Thanks for the additions. Is it ready to be merged? If so feel free to merge, or if you don't have the rights, let me know :) |
Yes, it is ready. Please merge it. |
This PR includes the following:
equal_matchmatching_type when array_type issparsecloses #544