Fix mission runner page refresh race condition. #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vue container in Active.vue was trying to use the MissionStore before it fully loaded, resulting in it being undefined. This adds a condition on the container to see if there is an active mission that is truthy and displays the content if it is. If there are active missions in the store, but there are none found (e.g. the UUID for the active mission is invalid in the route path), then it will display an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Vue container in Active.vue was trying to use the MissionStore before it fully loaded, resulting in it being undefined. This adds a condition on the container to see if there is an active mission that is truthy and displays the content if it is.
If there are active missions in the store, but there are none found (e.g. the UUID for the active mission is invalid in the route path), then it will display an error message.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue Number
unknown if any
Type of change
Please delete options that are not relevant.