Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HASE numerical bonuses. #2218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bluhman
Copy link

@Bluhman Bluhman commented Apr 21, 2023

Description

Makes it possible to use {hull}, {agi}, {sys}, and {eng} stat entries to Bonuses; similar to {ll} and {grit}.

Issue Number

n/a

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@msprijatelj
Copy link
Contributor

Oh nice! This seems convenient. I’m curious about what use case this is for?

@Bluhman
Copy link
Author

Bluhman commented Apr 22, 2023

Oh nice! This seems convenient. I’m curious about what use case this is for?

Potential core bonuses or effects that scale off of specific stats.

More to the point, I'm seeing if I can work on a rebalance of Lancer that transfers more scaling of Repair Cap from the Hull stat to Grit (achieved by making a 'base' reserve that applies the different scalings), and while I can get the points to scale up pretty well for Grit with something like:

{
        "id": "repcap",
        "val": "({grit}-1)/2",
        "overwrite": false,
        "replace": false
}

(Gain 1 RepCap every 2 points of Grit you have)
I want to be able to counteract/reduce the existing scaling by doing:

{
"id": "repcap",
"val": "(({hull}-2)/3)-(({hull}-1)/2)"
}

(Gain +1 RepCap every 3 points of Hull you have instead of 2. The math above might be wrong)

The applications beyond that could be interesting; I'm also aware of at least one homebrew that utilizes a mech that can swap out bonuses to Speed/Evasion between AGI and SYSTEMS that could also use this.

Tested this locally and affirmed that even the most broken use case I could think of (a HASE point bonus that scaled off of hull) was robust, didn't generate errors, even dynamically updated the number of points I had available to spend as I changed things, etc.

(checked documentation update, since it can be added to the Readme on https://github.com/massif-press/lancer-data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants