Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React to v16 #292

Merged
merged 6 commits into from
Feb 22, 2019
Merged

Update React to v16 #292

merged 6 commits into from
Feb 22, 2019

Conversation

zaki-yama
Copy link
Collaborator

ref. #290

@zaki-yama zaki-yama changed the title Update React to v16 [WIP]Update React to v16 Feb 20, 2019
@zaki-yama zaki-yama mentioned this pull request Feb 20, 2019
10 tasks
@stomita stomita merged commit 1ed6bdc into 3.0 Feb 22, 2019
@zaki-yama zaki-yama changed the title [WIP]Update React to v16 Update React to v16 Feb 22, 2019
@zaki-yama
Copy link
Collaborator Author

@stomita
Sorry for telling you after merged.

I found 2 problems when starting Storybook:

  1. The following warnings occurs.
setDefaults is deprecated. Instead, you can pass options into withInfo(options) directly, or use the info parameter.
Passing stories directly into withInfo() is deprecated, instead use addDecorator(withInfo) and pass options with the 'info' parameter

It's because I updated the Storybook and its addons' version.
We should deal with later.

  1. Some component raises propTypes error.
    ex. http://localhost:9001/?selectedKind=ButtonGroup&selectedStory=Inverse&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
Warning: Failed prop type: Invalid prop `type` of value `icon-border-inverse` supplied to `Button`, expected one of ["neutral","brand","destructive","inverse","icon","icon-bare","icon-container","icon-inverse","icon-more","icon-border","icon-border-filled"].

It also occurs in master branch, too.
I can deal with, but I can also ignore this because propTypes will be unnecessary after migrating to TypeScript.

@zaki-yama zaki-yama deleted the update-react branch February 22, 2019 10:39
@stomita
Copy link
Collaborator

stomita commented Feb 22, 2019

@zaki-yama ok these problems seem better to be handled in different PR. The proptype check could be ignored as it might not be so correct and would be replaced later by TS typecheck.

@zaki-yama
Copy link
Collaborator Author

@stomita
Sure. Thank you.

@zaki-yama zaki-yama self-assigned this Mar 12, 2019
@zaki-yama zaki-yama mentioned this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants