Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning & small modification #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleaning & small modification #200

wants to merge 2 commits into from
+28 −26

Conversation

ButuzGOL
Copy link
Contributor

@ButuzGOL ButuzGOL commented Apr 6, 2017

  1. dot configs to package.json
  2. clean empty files
  3. Add npm badge

@ButuzGOL
Cleaning & small modification
9fed8ef 
1. dot configs to package.json
2. clean empty files
3. Add npm badge
stomita
stomita reviewed Apr 8, 2017
View reviewed changes
Copy link
Collaborator

@stomita stomita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ButuzGOL
What is your purpose of moving .babelrc/.eslintrc to package.json ?

@ButuzGOL
Copy link
Contributor Author

Seems like storybook currently not supporting babel in package.json

@ButuzGOL
Copy link
Contributor Author

What is your purpose of moving .babelrc/.eslintrc to package.json ?

my opinion its much cleaner when all configs with several amount lines in one file

@stomita
Copy link
Collaborator

stomita commented Apr 10, 2017 •
edited

my opinion its much cleaner when all configs with several amount lines in one file

Not agree with your opinion. The package.json is less descriptive which cannot contain comment or other notation (.eslintrc.* does support YAML, JS, JSON format), and the developers cannot easily find where the configuration is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stomita stomita stomita left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ButuzGOL @stomita