Add support for building versions without Crashlytics #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR defines a supported way of building Jockey without any references to Crashlytics, which is disallowed from builds of apps on F-Droid because it is closed source. See discussion in #388 for more info.
This PR also removes the option to opt-out of additional logging, because it wouldn't actually disable any additional logging in the current build of the app. Previous versions of Jockey sent anonymous analytics about library usage, but all such metrics have since been removed.
Additionally, the first-launch dialog with a link to Jockey's privacy policy has been removed. This dialog would only show a link to Jockey's privacy policy since the opt-out option is no longer applicable, and since the privacy policy is accessible both in-app and on the Play Store listing, it isn't necessary to show it to the user on the first launch.
Changes to builds
There are now three build variants of Jockey:
For a FOSS build to actually exclude the Crashlytics dependency, you must also specify the
-PdisableCrashlytics
flag to Gradle. If building from the command line, you can generate an APK appropriate for F-Droid by executing the following command from the root of the repository:(on Windows, use
gradlew
instead of./gradlew
)APK Contents
FOSS build variant with -PdisableCrashlytics:
Hathor build variant with no additional flags: