Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building versions without Crashlytics #393

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

marverenic
Copy link
Collaborator

Overview

This PR defines a supported way of building Jockey without any references to Crashlytics, which is disallowed from builds of apps on F-Droid because it is closed source. See discussion in #388 for more info.

This PR also removes the option to opt-out of additional logging, because it wouldn't actually disable any additional logging in the current build of the app. Previous versions of Jockey sent anonymous analytics about library usage, but all such metrics have since been removed.

Additionally, the first-launch dialog with a link to Jockey's privacy policy has been removed. This dialog would only show a link to Jockey's privacy policy since the opt-out option is no longer applicable, and since the privacy policy is accessible both in-app and on the Play Store listing, it isn't necessary to show it to the user on the first launch.

Changes to builds

There are now three build variants of Jockey:

  • Hathor - the primary variant used for Google Play releases
  • FOSS - a variant that does not include references to Crashlytics
  • Marketing - used to generate promotional screenshots with a fake music library

For a FOSS build to actually exclude the Crashlytics dependency, you must also specify the -PdisableCrashlytics flag to Gradle. If building from the command line, you can generate an APK appropriate for F-Droid by executing the following command from the root of the repository:

./gradlew assembleFossRelease -PdisableCrashlytics

(on Windows, use gradlew instead of ./gradlew)

APK Contents

FOSS build variant with -PdisableCrashlytics:
image

Hathor build variant with no additional flags:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants