Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

WIP - Obscure value mocking #161

Closed
wants to merge 2 commits into from

Conversation

RazzM13
Copy link
Contributor

@RazzM13 RazzM13 commented May 5, 2018

Fixes #160

@RazzM13 RazzM13 changed the title Issue #160 WIP - Issue #160 May 5, 2018
@martysweet martysweet added the WIP label May 6, 2018
@martysweet
Copy link
Owner

@RazzM13 is this still WIP?

@RazzM13
Copy link
Contributor Author

RazzM13 commented Jun 4, 2018

Hi @martysweet, basically I already have the code for this now (needs a bit of cleaning up though) but I believe that some changes will be required to integrate with SAM that relate to work items 2 and 3 and therefore I was hoping to delay this until SAM support is in, in order to avoid some merge conflicts. How do you feel about it?

@martysweet martysweet changed the title WIP - Issue #160 WIP - Obscure value mocking Jun 4, 2018
@martysweet martysweet added this to the v1.8.0 milestone Jun 4, 2018
@martysweet
Copy link
Owner

Ok, lets put this along with the other changes into the v1.8.0 release. #167 and #156 are going to clash horribly so we need to work out the best order to merge them in.

@RazzM13
Copy link
Contributor Author

RazzM13 commented Jun 4, 2018

I was actually wondering about that too, though I haven't really had a chance to look at the changes imposed by #156, perhaps @akdor1154 can shed some light upon the matter ...

@martysweet martysweet modified the milestones: v1.8.0, v1.9.0 Aug 2, 2018
@RazzM13
Copy link
Contributor Author

RazzM13 commented Oct 30, 2018

Hey @martysweet, now that SAM support is in master, should I now have a look at this?

@martysweet
Copy link
Owner

Sounds like a plan @RazzM13. We have #198 which this type of functionality could have been helpful in.

…hat exhibits a dual role of notifying a user about the mocked values that are in play as well as keeping track of potential value conflicts for the same attribute that may arrise during runtime and, notifying if such a conflict occurs.
@RazzM13
Copy link
Contributor Author

RazzM13 commented Nov 4, 2018

Hey @martysweet, just managed to implement the centralized mocking functions based on the attribute type as well as contextual resolution (place within intrinsic or within a given resource/property type). I believe that we've now fully covered the proposed enhancements of #160 therefore, please have a look over everything and let me know if something is missing, incorrect or otherwise.

One thing that I feel I should mention is that we don't currently have support for mocking entire structures (i.e. resource / resource-property types), I believe that this shouldn't really be too difficult to add however, I'm not really sure of how much use this may be...

PS: I've noticed that Fn::Sub and Fn::Join intrinsics, and maybe others, don't attempt to resolve all of their arguments, I'm wondering if this should actually be happening and if so perhaps we should open an issue on this as it does appear to be quite business critical.

@RazzM13
Copy link
Contributor Author

RazzM13 commented Dec 4, 2018

Hey @martysweet, apart from the merge conflict is there anything else that is blocking this? :)

@martysweet martysweet closed this Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants