Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Commit

Permalink
Issue #214 SQS Queues now accept Tags (#216)
Browse files Browse the repository at this point in the history
Issue #214 add tests for SQS Queues Tags
  • Loading branch information
tomdionysus authored and martysweet committed Dec 9, 2018
1 parent 5c1cef2 commit e1f4bbf
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Expand Up @@ -6,6 +6,12 @@ and this project adheres to [Semantic
Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Changed
- Update CloudFormation specification (downloaded 07-Dec-2018) - version: 2.17.0
- Manually edit specification to fix incorrect type setting on AWS::ServiceDiscovery::Instance.InstanceAttributes

### Added
- Merge PR #216, adding tests for SQS tags

## [1.9.3] - 2018-12-04
### Changed
Expand Down
5 changes: 3 additions & 2 deletions data/aws_resources_specification.json
Expand Up @@ -25262,7 +25262,8 @@
"InstanceAttributes": {
"Required": true,
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-servicediscovery-instance.html#cfn-servicediscovery-instance-instanceattributes",
"PrimitiveType": "Json",
"Type": "Map",
"PrimitiveItemType": "String",
"UpdateType": "Mutable"
},
"InstanceId": {
Expand Down Expand Up @@ -31891,5 +31892,5 @@
}
}
},
"ResourceSpecificationVersion": "2.16.0"
"ResourceSpecificationVersion": "2.17.0"
}
7 changes: 7 additions & 0 deletions src/test/validatorTest.ts
Expand Up @@ -924,6 +924,13 @@ describe('validator', () => {
expect(result).to.have.deep.property('templateValid', true);
expect(result['errors']['crit']).to.have.lengthOf(0);
});

it('Issue #214 - SQS Queues now accept Tags', function () {
var input = 'testData/valid/yaml/issue-214-sqs-queues-now-accept-tags.yaml';
var result = validator.validateFile(input);
expect(result).to.have.deep.property('templateValid', true);
expect(result['errors']['crit']).to.have.lengthOf(0);
});
});

describe('parameters-validation', () => {
Expand Down
9 changes: 9 additions & 0 deletions testData/valid/yaml/issue-214-sqs-queues-now-accept-tags.yaml
@@ -0,0 +1,9 @@
AWSTemplateFormatVersion: "2010-09-09"
Description: "AWS CloudFormation Template to demonstrate AWS:SQS:Queue accepting Tags"
Resources:
DNSVPCDomain:
Type: "AWS::SQS::Queue"
Properties:
Tags:
- Key: Name
Value: TestName

0 comments on commit e1f4bbf

Please sign in to comment.