Fix GetAtt shorthand not accepting array parameters (#165)

* "Fn::GetAtt" argument has two forms, one as string and the other as array.

* Fixed code style issue.

* Add shorthand getatt test for parser

* Add changelog

CHANGELOG.md

@@ -6,6 +6,8 @@ and this project adheres to [Semantic
 Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Merge PR #165, fixing GetAtt shorthand not accepting array parameters
 
 ## [1.7.0] - 2018-05-06
 ### Fixed

src/test/parserTest.ts

@@ -22,6 +22,12 @@ describe('parser', () =>{
             expect(result).to.not.equal(null);
         });
 
+        it('valid yaml !GetAtt as array should return valid javascript object', () => {
+            let result = parser.openFile("./testData/valid/yaml/issue_164_getatt_shorthand_parsing.yaml");
+            expect(result).to.not.equal(undefined);
+            expect(result).to.not.equal(null);
+        });
+
         it('invalid yaml should throw an Error', () => {
             let fn = function(){ parser.openFile("./testData/invalid/yaml/invalid_yaml.yaml"); };
             expect(fn).to.throw(/Could not determine file type. Check your template is not malformed./);

src/yamlSchema.ts

@@ -26,7 +26,7 @@ export function buildYamlType(fnName: string, kind: YamlKind) {
     const tag = `!${tagName}`;
 
     const constructFn = (fnName === 'Fn::GetAtt')
-        ? (data: any) => ({'Fn::GetAtt': data.split('.')})
+        ? (data: any) => ({'Fn::GetAtt': Array.isArray(data) ? data : data.split('.')})
         : (data: any) => ({[fnName]: data});
 
     return new yaml.Type(tag, {

testData/valid/yaml/issue_164_getatt_shorthand_parsing.yaml

@@ -0,0 +1,9 @@
+Resources:
+  Bucket:
+    Type: AWS::S3::Bucket
+
+Outputs:
+  output1:
+    Value: !GetAtt
+      - Bucket
+      - Arn