Added support for "Fn::ImportValue" to "Fn::Split" intrinsic function. (

#171)
martysweet · Jun 30, 2018 · 645ce2a · 645ce2a
1 parent 0f6f1b5
commit 645ce2a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/data/aws_intrinsic_functions.json b/data/aws_intrinsic_functions.json
@@ -13,7 +13,7 @@
   "Fn::Select": {},
   "Fn::Select::Index": {"supportedFunctions": ["Ref", "Fn::FindInMap"]},
   "Fn::Select::List": {"supportedFunctions" : ["Fn::FindInMap", "Fn::GetAtt", "Fn::GetAZs", "Fn::If", "Fn::Split", "Ref"] },
-  "Fn::Split": {"supportedFunctions": ["Fn::Base64", "Fn::FindInMap", "Fn::GetAtt", "Fn::If", "Fn::Join", "Fn::Select", "Ref"]},
+  "Fn::Split": {"supportedFunctions": ["Fn::Base64", "Fn::FindInMap", "Fn::GetAtt", "Fn::If", "Fn::Join", "Fn::Select", "Fn::ImportValue", "Ref"]},
   "Fn::Sub": { "supportedFunctions": ["Fn::Base64", "Fn::FindInMap", "Fn::GetAtt", "Fn::GetAZs", "Fn::If", "Fn::Join", "Fn::Select", "Ref"]},
   "Ref": {}
 }
diff --git a/src/test/validatorTest.ts b/src/test/validatorTest.ts
@@ -887,6 +887,13 @@ describe('validator', () => {
             expect(result['errors']['crit']).to.have.lengthOf(1);
             expect(result['errors']['crit'][0]).to.have.property('message', 'Expecting a list, got null');
         });
+
+        it('Fn::Split should support function "Fn::ImportValue"', () => {
+            const input = 'testData/valid/yaml/issue-170.yaml';
+            let result = validator.validateFile(input);
+            expect(result).to.have.deep.property('templateValid', true);
+            expect(result['errors']['crit']).to.have.lengthOf(0);
+        });
     });
 
     describe('parameters-validation', () => {

diff --git a/testData/valid/yaml/issue-170.yaml b/testData/valid/yaml/issue-170.yaml
@@ -0,0 +1,10 @@
+Parameters:
+  SomeParameterValue:
+    Type: String
+
+Resources:
+  MyBucket:
+    Type: AWS::S3::Bucket
+    Properties:
+      BucketName:
+        !Select [0, !Split [',', !ImportValue SomeParameterValue]]