Switch to re2 library #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The re2 library, though not offering the complete functionality of pcre, is known to be much faster in many scenarios. Switch to re2 in preparation for the OTP switch to re2 in OTP28
|
There are some issues with using re2 in riak. It is not possible to pass/use a reference to a compiled regular expression between nodes. Further there are significant performance benefits to using filter expressions rather than regular expression. This is a better way to improve filter speed. So the intention is now to wait for the OTP-implemented version to be available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The re2 library, though not offering the complete functionality of pcre, is known to be much faster in many scenarios.
Switch to re2 in preparation for the OTP switch to re2 in OTP28