Mas i1826 pollpush #376
Open
Mas i1826 pollpush #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have a regular poll, so even if writes stop, if there is an excessively large ledger cache it will eventually be pushed
Rather than rely on a continuous timed poll, use journal compaction instead. This of course won't help in head_only mode, but makes the change much smaller. Journal compaction already has windows, and random jittering - so no need to duplicate this.
|
Same concept now included in #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a backlog in the penciller, but all writes stop, there will be no trigger to push the build-up in-memory to disk.
Now, on journal compaction there will be an additional push of the ledger cache (if it is over the maximum size) that will prompt this as a result of that compaction