-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors when calling df.agg("nunique")
#2970
Draft
wjsi
wants to merge
5
commits into
mars-project:master
Choose a base branch
from
wjsi:bugfix/groupby_nunique
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjsi
added
type: bug
Something isn't working
mod: dataframe
to be backported
Indicate that the PR need to be backported to stable branch
labels
Apr 26, 2022
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
5 times, most recently
from
April 27, 2022 06:49
20c97da
to
4d1e7b4
Compare
wjsi
changed the title
[WIP] Fix support for groupby-nunique
Use map-combine-agg to execute Apr 27, 2022
groupby.nunique
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
from
April 28, 2022 07:36
bbf6e18
to
5069080
Compare
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
from
May 5, 2022 12:44
5069080
to
6f52547
Compare
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
5 times, most recently
from
May 7, 2022 03:46
7a1b55d
to
2e2aa9d
Compare
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
from
May 7, 2022 06:07
2e2aa9d
to
63c45fb
Compare
wjsi
changed the title
Use map-combine-agg to execute
Fix errors when calling May 7, 2022
groupby.nunique
df.agg("nunique")
wjsi
force-pushed
the
bugfix/groupby_nunique
branch
from
May 7, 2022 10:24
63c45fb
to
5c67580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mod: dataframe
to be backported
Indicate that the PR need to be backported to stable branch
type: bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix incorrect redirection of
groupby.nunique
intotransform
by applying map-combine-agg paradigm.Related issue number
Fixes #xxxx
Check code requirements