Fix Concurrent Deployment Issue via Zookeeper #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
previously approved these changes
May 21, 2024
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
…qo-ai/marqo into li/fix-concurrent-deployment
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
May 22, 2024
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix, feature
What is the current behavior? (You can also link to an open issue here)
We don't have any concurrency protection on create/delete index.
If multiple threads are creating/deleting indexes at the same time, Marqo will face a race condition
What is the new behavior (if this is a feature change)?
We use the Zookeeper inside Vespa to implement a distributed lock. The lock will solve the concurrent issue.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
in progress
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
no
Other information:
no
Please check if the PR fulfills these requirements