GROVE-334 : adds 'show more' link to show more facets in the Vue template #9
Conversation
|
This looks good to @withjam, @dalaidunc, and me. Waiting for final review from @grtjn when he's back from holiday before it is merged. |
|
Mike, you worked against master, rather than development. That probably explains why it is showing some commits from Marianne right now. It makes it easier to review if the PR only shows the relevant commits. Not a big deal though, and it doesn't seem to cause trouble for merging.. |
package.json
Outdated
| @@ -25,7 +34,6 @@ | |||
| "start": "cross-env NODE_ENV=development nodemon node-app.js", | |||
| "start:prod": "node node-app.js" | |||
| }, | |||
| "private": true, | |||
There was a problem hiding this comment.
@mariannemyers it looks like you dropped the private flag, and published grove-node on npm, but it was marked as private on purpose. grove-node is part of the grove templates, not a package.. Let's discuss in the next meeting what we do with this..
| authed: true | ||
| }, | ||
| { | ||
| endpoint: '/config/query/all', // NOTE: allows get on all extensions |
There was a problem hiding this comment.
Allows getting the 'all' search options..
There was a problem hiding this comment.
I think it would be nice if we would expose proper rest endpoints for both of these. so, maybe /search/all/config for the latter, and /search/all/values for the first. It might be possible to leverage this work to rewrite those calls to other urls against ML: #29
From top of my head, something like:
route.use('/search/' + type, routeFactory.defaultExtensionRoute({
authProvider,
actions: {
config: {
uri: '/v1/config/query/all',
GET: function(body, params, req){
return {
method: req.method,
body: '',
params: {}
}
}
}
}
It may be necessary to patch either the default search or default ext route to fall through, otherwise one or the other might not get reached..
There was a problem hiding this comment.
Could you have a play with that @janmichaelyu ?
grtjn
force-pushed
the
development
branch
2 times, most recently
from
933b8b8
to
c3e5465
Compare
| } | ||
| }) | ||
| ); | ||
|
|
There was a problem hiding this comment.
Sorry for taking so long, but after rethinking about this, I am thinking we should not need a separate /search/similar endpoint. Instead, similar should just be 'yet another constraint' in the existing all.xml. Could you revisit this PR (you will have to open a new one unfortunately), and move that custom constraint into all.xml?
https://github.com/marklogic-community/grove-ml-gradle/pull/3/files
No description provided.