This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Add ability to change the sort used in a search #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add tests around isAuthorized() while we are at it. I note that the API spec prefers `errorMessage` to `message`, but I proposed in Jira that we modify the spec instead.
getAuth is going to throw an Unauthorized error. If we don't care about authentication, we send the request anyway. Tests would be nice to maintain this behavior.
Let's be a bit more careful here and throw errors other than "Unauthorized", so we don't accidentally swallow something.
for the proxy to MarkLogic. Both are viable prefixes for MarkLogic.
…ntage of built in features ie. rolling/refreshing sessions and expiration to replace custom code
…tore the hashed username:realm:password in the session securely
#25: added initial implementation of default route for rest extensions
#31: added default ping route, including call to backend ping extension
…re-api Various robustness updates
Feature/26 crud actions
This was referenced Jan 31, 2020
Open
grtjn
reviewed
Apr 9, 2020
| endpoint: '/config/query/*', | ||
| methods: ['get'], | ||
| authed: true | ||
| } |
There was a problem hiding this comment.
would be nice if we could get that addition of mine working with this instead..
|
Note to self @mariannemyers - you'll need to refactor this now that grove-react-ui had its related packages folded in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding the sort to the operator-state.
For now this does use the legacy /v1/config/query route. I was not able to get the sample call using the defaultExtensionRoute (routes/api/index.js:65) to work; I kept getting a 405.
Relates to "sibling" PRs:
marklogic-community/grove-core-react-components#10
marklogic-community/grove-search-redux#9
marklogic-community/grove-core-react-redux-containers#10