Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basename support for crawl mode #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexlande
Copy link

@alexlande alexlande commented Mar 16, 2017

馃憢

I tried out the new crawl mode today, and it's awesome!

My app uses basename with React Router to handle deployment to GitHub pages, so my routes look like /about, but the deployed URLs look like /project-name/docs/about. This broke the crawler, understandably. It generated the pages but put all of them after the index in a nested subdirectory that matched the basename.

This change lets you pass in a basename so that the crawler will disregard it, and all of the pages get built correctly. If you're interested in something like this let me know and I can add some tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.107% when pulling 7a6e592 on alexlande:feature-basenameCrawling into 09001fe on markdalgleish:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants