Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip query and hash from path when creating asset name #114

Closed
wants to merge 4 commits into from

Conversation

jahredhope
Copy link
Collaborator

When choosing an asset name attempt to strip out query and hash from the path.

This change attempts to fix
#113
and may relate to
#109

When initially cloning the repo tests were failing, this may be due to my Node version (v8.4.0) or other environmental factors. However I was unable to fix the broken tests.

Failing Tests

compression
      1) generates the expected HTML files
legacy-args
      2) generates the expected HTML files
require-ensure
      3) generates the expected HTML files

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 312870a on jahredhope:master into 09001fe on markdalgleish:master.

@coveralls
Copy link

coveralls commented Aug 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8e7ccdb on jahredhope:master into 09001fe on markdalgleish:master.

@jahredhope
Copy link
Collaborator Author

Closed in favour of #140

@jahredhope jahredhope closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants