Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude query and hash from path when crawling links #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exclude query and hash from path when crawling links #140

wants to merge 1 commit into from

Conversation

jahredhope
Copy link
Collaborator

@jahredhope jahredhope commented Nov 19, 2018 •
edited

Re-creates #114 due to branch changes

When crawling links to render a link such as /foo?bar will attempt to create file /foo?bar.html this may not be ideal. This change has the link crawl behaviour ignore query parameters and hashes by using the url's pathname instead of path.

closes #113
closes #109

@jahredhope jahredhope mentioned this pull request Nov 19, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 941663b on jahredhope:strip-hash-route into 69d2b22 on markdalgleish:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crawl: Error when url contains query parameter Having url's with a hash (#) in it, creates an endless loop
2 participants
@jahredhope @coveralls